Calibrate qualified peer did tests to acapy PR 2862 #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheldon Regular <[email protected]>
swcurran
approved these changes
Apr 17, 2024
|
Besides the last test in this suite waiting for 2891, all the OOB tests are failing and waiting on ACA-Py PR 2897. openwallet-foundation/acapy#2897 |
|
Thanks @nodlesh -- oob pr merged. Can you manually trigger another run of AATH? I'm not sure how to do that in the Actions interface? |
|
Done. Running the acapy-acapy runset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accounts for the ACA-Py qualified peer did updates made in PR 2862, openwallet-foundation/acapy#2862
The biggest change here is that we no longer need to restart the agents with different did peer methods as a command line option. Peer did method is now on the API calls themselves. I'm leaving in the code that restarts agents just in case other frameworks require a restart to work with a new peer did method.
Note that test T003-RFC0793 will fail until ACA-Py PR 2891 is merged. openwallet-foundation/acapy#2891